Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docs build on tags without explicitly adding OndaEDFSchemas #79

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix docs build on tags without explicitly adding OndaEDFSchemas #79

merged 2 commits into from
Jul 14, 2023
+2 −3

Conversation

kleinschmidt
Copy link
Member

The documenter build is failing on tags but not on the other builds. I think this is because the other builds, we explicitly dev the local version of OndaEDFSchemas, but on tags we don't. This PR fixes the docs build by using OndaEDF.OndaEDFSchemas instead of OndaEDFSchema directly.

@kleinschmidt kleinschmidt requested a review from palday July 13, 2023 21:43
palday
palday approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let's try this and see if it works 😄

@kleinschmidt kleinschmidt merged commit 8c3ac67 into master Jul 14, 2023
@kleinschmidt kleinschmidt deleted the dfk/docs-tags-fix branch July 14, 2023 16:07
@kleinschmidt
Copy link
Member Author

seems to have worked! https://beacon-biosignals.github.io/OndaEDF.jl/stable/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palday palday palday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleinschmidt @palday